Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for the utils package #34

Merged
merged 5 commits into from
May 19, 2024
Merged

Tests for the utils package #34

merged 5 commits into from
May 19, 2024

Conversation

yannick2009
Copy link
Contributor

Launch go test -cover ./pkg/utils to run the tests and see the percentage of coverage.

@theredditbandit
Copy link
Owner

Just a heads up for future potential PRs , if the ci is failing like it was now you probably need to run the gci formatter like so

gci write -s standard -s default -s 'prefix(github.com/theredditbandit/pman)' .

theredditbandit
theredditbandit requested changes May 17, 2024
View reviewed changes
pkg/utils/utils.go Outdated Show resolved Hide resolved
@theredditbandit
Copy link
Owner

Thanks a lot for your changes @yannick2009! , this is huge. I really appreciate your contributions to pman!

@theredditbandit theredditbandit merged commit 4e79bd5 into theredditbandit:master May 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theredditbandit theredditbandit theredditbandit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannick2009 @theredditbandit